-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime-sdk/modules/evm: Add support for simulating CREATE #1669
Conversation
✅ Deploy Preview for oasisprotocol-oasis-sdk canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1669 +/- ##
==========================================
- Coverage 65.34% 65.33% -0.01%
==========================================
Files 114 114
Lines 8365 8380 +15
==========================================
+ Hits 5466 5475 +9
- Misses 2899 2905 +6 ☔ View full report in Codecov by Sentry. |
fb2417a
to
da8c76e
Compare
da8c76e
to
c9b9a9d
Compare
c9b9a9d
to
44eaec5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems errors & reversions aren't being handled when simulating a contract creation via eth_call.
Oh, my bad, need to update oasis-web3-gateway to specify nil as the to
field.
I need to test against updated oasis-web3-gateway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…ostko/feature/evm-simulate-create runtime-sdk/modules/evm: Add support for simulating CREATE a9c70cb
No description provided.