Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime-sdk/modules/evm: Add support for simulating CREATE #1669

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

kostko
Copy link
Member

@kostko kostko commented Mar 26, 2024

No description provided.

Copy link

netlify bot commented Mar 26, 2024

Deploy Preview for oasisprotocol-oasis-sdk canceled.

Name Link
🔨 Latest commit 44eaec5
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-oasis-sdk/deploys/6602c8ec643ec00008dbfecb

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 81.03448% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 65.33%. Comparing base (da60d8d) to head (44eaec5).

Files Patch % Lines
runtime-sdk/modules/evm/src/lib.rs 76.59% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1669      +/-   ##
==========================================
- Coverage   65.34%   65.33%   -0.01%     
==========================================
  Files         114      114              
  Lines        8365     8380      +15     
==========================================
+ Hits         5466     5475       +9     
- Misses       2899     2905       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kostko kostko force-pushed the kostko/feature/evm-simulate-create branch from fb2417a to da8c76e Compare March 26, 2024 12:28
@kostko kostko force-pushed the kostko/feature/evm-simulate-create branch from da8c76e to c9b9a9d Compare March 26, 2024 12:46
@kostko kostko force-pushed the kostko/feature/evm-simulate-create branch from c9b9a9d to 44eaec5 Compare March 26, 2024 13:08
Copy link
Member

@CedarMist CedarMist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems errors & reversions aren't being handled when simulating a contract creation via eth_call.

Oh, my bad, need to update oasis-web3-gateway to specify nil as the to field.

@CedarMist CedarMist dismissed their stale review March 27, 2024 11:41

I need to test against updated oasis-web3-gateway

Copy link
Member

@CedarMist CedarMist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kostko kostko merged commit a9c70cb into main Mar 27, 2024
29 checks passed
@kostko kostko deleted the kostko/feature/evm-simulate-create branch March 27, 2024 14:37
github-actions bot added a commit that referenced this pull request Mar 27, 2024
…ostko/feature/evm-simulate-create

runtime-sdk/modules/evm: Add support for simulating CREATE a9c70cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants